This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Fixed PR 343138 - Contact fields with Chinese characters are returned as... #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we were unescaping, don't we still need to do so? |
|
@jeffheifetz I am not removing the unescaping, I just replaced those calls with |
|
I know, but the issue is that escape will handle "'" characters. Should we perhaps be doing both? |
|
@jeffheifetz Read this link about unescape() vs. decodeURIComponent() |
|
@rwmtse I have read the link and can tell you from personal experience that they handle different things. |
… as ?? when searching with PIM APIs
|
@jeffheifetz Using both now |
|
r+? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... ?? when searching with PIM APIs
@bryanhiggins @erikjohnzon
I will port this to cordova-blackberry-plugins soon.